Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update test suite to newer relevant binaries #1285

Merged
merged 29 commits into from
Oct 19, 2024

Conversation

boojamya
Copy link
Contributor

This PR updates the binaries used in CI to a more relevant version. I've chosen ibc-go-simd v8.5.1.

Note: I am unsure if this will pass all tests. Feel free to do with this PR as you wish.

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 11:49pm

@Reecepbcups
Copy link
Member

if any upgrade test do fail, it could be due to how halt heights work in v44/45 (at height) vs v47+ (height+1) in my experience. so any block off by 1 errors that you see are probably related to that

further, test are still flakey but I have a PR pending regiew for a month that fixes flakeyness. So if you want to merge that in here I can approve & merge once all CI passes

@Reecepbcups
Copy link
Member

Reecepbcups commented Oct 17, 2024

#1263

you can also ignore markdown link check for now

@Reecepbcups
Copy link
Member

Reecepbcups commented Oct 18, 2024

@boojamya Ill take a look at this tomorrow if you can enable maintainer edits on this PR for me :)

@Reecepbcups Reecepbcups marked this pull request as ready for review October 18, 2024 23:16
@Reecepbcups Reecepbcups requested a review from a team as a code owner October 18, 2024 23:16
@Reecepbcups
Copy link
Member

Thanks dan!

@Reecepbcups Reecepbcups enabled auto-merge (squash) October 18, 2024 23:17
@Reecepbcups Reecepbcups changed the title chore: update test suite to relevant binaries chore: update test suite to newer relevant binaries Oct 18, 2024
@Reecepbcups Reecepbcups merged commit 664ae63 into strangelove-ventures:main Oct 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants