Skip to content

Commit

Permalink
reduce test flakiness by only verifying with rly
Browse files Browse the repository at this point in the history
  • Loading branch information
Reecepbcups committed Sep 20, 2024
1 parent 64182e1 commit 78418f6
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions examples/ibc/ics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package ibc_test
import (
"context"
"fmt"
"os"
"strings"
"testing"

Expand Down Expand Up @@ -32,12 +33,17 @@ func TestICS(t *testing.T) {
icsVersions = []string{ver}
}

relayers := []struct {
type relayerTypes struct {
rly ibc.RelayerImplementation
name string
}{
{rly: ibc.Hermes, name: "hermes"},
{rly: ibc.CosmosRly, name: "rly"},
}
relayers := []relayerTypes{{rly: ibc.CosmosRly, name: "rly"}}

// t / true
if strings.HasPrefix(os.Getenv("ICT_WITH_HERMES"), "t") {
// reduces test flakeyness in CI, no need to verify with Hermes
// we just need to confirm the ICS works as expected with respect to migrations.
relayers = append(relayers, relayerTypes{rly: ibc.Hermes, name: "hermes"})
}

for _, version := range icsVersions {
Expand Down

0 comments on commit 78418f6

Please sign in to comment.