ci: configure additional CI jobs & bring linter settings in compliance with OSS template #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add back the importas linter since it seemed to be used still. Remove dogsled configuration since we no longer use it. Disable the float-compare rule in testifylint because it is not helpful in the few cases we do float comparisons in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Go version to 1.23 & adds some additional CI jobs:
It also tweaks the golangci-lint settings to be in compliance with the OSS template.
All repo settings should also be in compliance with the OSS template now.
TODO: Do we bring the build & test CI job and the goreleaser CI job into compliance with the OSS template or do we leave the currently configured settings?