Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor necessary comet #241

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

vendor necessary comet #241

wants to merge 9 commits into from

Conversation

agouin
Copy link
Member

@agouin agouin commented Dec 22, 2023

rather than fork comet, we can tree shake and bring in only the components needed by horcrux in order to support bn254.

@nitronit
Copy link
Contributor

Hey @agouin, I know you guys are putting a lot of effort in Horcrux but this looks pretty un-gophy and very anti-pattern TBH!
And looks like a nightmare to support/debug etc etc.

My take on this is:

  • The cosigners/mpc should never know or bother what it is trying to "organise".
  • This is/should be the role of the threshold_validator (the server for the sentry/cometbft client). Basically a proxy in front of the MPC.
  • The same should almost apply for the MPC (cosigners) with regards to the tss.

Happy holidays!

@agouin
Copy link
Member Author

agouin commented Jan 17, 2024

@nitronit I appreciate you taking the time to look through the horcrux PRs, I can assure you that this is very much an experiment of removing the comet dependency to avoid a fork and not representative of how things will be organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants