Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature branch: use Symfony docker #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature branch: use Symfony docker #98

wants to merge 1 commit into from

Conversation

COil
Copy link
Member

@COil COil commented Oct 20, 2024 •
edited
Loading

Use dunglas/symfony-docker to run the project with Docker instead of the Symfony binary.

Q A
Branch? symfony-docker
Cleanup? no
Bug fix? no
Fixed tickets NA
New feature? yes
Doc added? no
Tests pass? yes
Deprecations? no
License MIT

@COil COil added DX Developer Experience FrankenPHP Related to FrankenPHP feature branch Feeature branch demo wip labels Oct 20, 2024
@COil COil self-assigned this Oct 20, 2024
@COil COil changed the title feat: use Symfony docker feature branch: use Symfony docker Oct 20, 2024
@COil COil removed the wip label Oct 27, 2024
florentdestremau
florentdestremau reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@florentdestremau florentdestremau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering using this template for a side project and I would love to use Docker with it, so here's my review :)

.editorconfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the editorconfig has a place here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @florentdestremau, this branch needs a rebase from main as it is quite old now.

Capture d’écran 2025-01-28 à 17 00 36

.gitattributes Show resolved Hide resolved
assets/vendor/@hotwired/turbo/turbo.index.js Show resolved Hide resolved
composer.json Show resolved Hide resolved
@COil
Copy link
Member Author

COil commented Jan 29, 2025

I'm considering using this template for a side project and I would love to use Docker with it, so here's my review :)

Would you like to do the rebase ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florentdestremau florentdestremau florentdestremau left review comments

Assignees

@COil COil

Labels
DX Developer Experience feature branch Feeature branch demo FrankenPHP Related to FrankenPHP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@COil @florentdestremau