feat: enable PHPStan bleeding edge mode #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
COil
commented
Oct 4, 2024
COil
commented
- https://phpstan.org/blog/what-is-bleeding-edge
- https://phpstan.org/config-reference#bleeding-edge
COil
commented
Oct 4, 2024
| $percentage = min(100, max(0, (int) $argv[2])); | ||
|
|
||
| if (!file_exists($inputFile)) { | ||
| throw new InvalidArgumentException('Invalid input file provided'); | ||
| } | ||
|
|
||
| if (!is_int($percentage)) { |
There was a problem hiding this comment.
Detected by PHPStan bleeding edge:
------ ----------------------------------------------------------------------------------------------------------------------
Line bin/coverage-checker.php
------ ----------------------------------------------------------------------------------------------------------------------
14 Call to function is_int() with int<0, 100> will always evaluate to true.
🪪 function.alreadyNarrowedType
💡 Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false
in your phpstan.neon.
------ ----------------------------------------------------------------------------------------------------------------------
COil
commented
Oct 4, 2024
| @@ -18,6 +19,8 @@ | |||
|
|
|||
| /** | |||
| * @see RegisterFormDto | |||
| * | |||
| * @extends AbstractType<RegisterFormDto> | |||
There was a problem hiding this comment.
Detected by PHPStan bleeding edge:
------ ----------------------------------------------------------------------------------------------------------------------------------
Line src/Form/Type/RegisterForm.php
------ ----------------------------------------------------------------------------------------------------------------------------------
22 Class App\Form\Type\RegisterForm extends generic class Symfony\Component\Form\AbstractType but does not specify its types: TData
🪪 missingType.generics
------ ----------------------------------------------------------------------------------------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.