-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-generated smoke tests #59
Conversation
Thanks for PR @Pierstoval, check out |
147e6f5
to
9576de4
Compare
Done 👌 |
Hello,
Ok for php-cs-fixer but there are some PHPStan warnings.
To ensure the CI will pass, you can run (with xdebug enabled)
Or for phpstan only :
|
* | ||
* @author Alex "Pierstoval" Rock <[email protected]> | ||
*/ | ||
class StaticRoutesSmokeTest extends WebTestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AutomatedSmokeTest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test case doesn't cover dynamic route, automation is only related to specific routes, aka the static ones. I think adding "automated" would be too generic and less informative about what it actually does.
|
||
static::bootKernel(); | ||
|
||
/** @var TestContainer $container */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure these @var annotations are needed with the Symfony PHPStan plugin, to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed not necessary for PHPStan, but it might be necessary for some IDEs that don't understand Symfony's DI rules. Some static analysers relying only on PHPDoc will also understand annotations better. I think we should keep it.
9576de4
to
3b86419
Compare
3b86419
to
f9388c5
Compare
Thanks @Pierstoval :) |
Extracted from https://github.com/Pierstoval/SmokeTesting , as @COil doesn't want a Composer dependency for that, and the concept is straightforward anyway