Whinepad: Let 0 be defaultValue of rating for a new record #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If you do not click a star when you add a new records, the value of rating is
NaN
because ofparseInt('', 10)
.JSON.stringify
writesNaN
asnull
, thereforetoString
will fail during some text searches in the next session when the data has been deserialized.Solution: Delete conditional expression and
parseInt
at intermediate levels of the component tree so leaf components receiveundefined
asdefaultValue
of fields for a new record.Steps to verify with console pane open in the browser:
TypeError: row[fields[f]] is null
Sorry about the whitespace changes. Atom editor has to make its mark ;)
P.S. Thank you very much for writing React Up & Running! Your previous JavaScript Patterns was super helpful to me too.