Skip to content

Commit

Permalink
Merge pull request #29273 from storybookjs/dannyhw/feat/rnv8-update-c…
Browse files Browse the repository at this point in the history
…reate-generator

CLI: Update the React Native init to include v8 dependencies
(cherry picked from commit 3988207)
  • Loading branch information
shilman committed Oct 4, 2024
1 parent e1d0400 commit b5af0c8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
11 changes: 8 additions & 3 deletions code/lib/create-storybook/src/generators/REACT_NATIVE/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,19 @@ const generator = async (

const reactVersion = packageJson.dependencies.react;

const controlsPeerDependencies = [
const peerDependencies = [
'react-native-safe-area-context',
'@react-native-async-storage/async-storage',
'@react-native-community/datetimepicker',
'@react-native-community/slider',
'react-native-reanimated',
'react-native-gesture-handler',
'@gorhom/bottom-sheet',
'react-native-svg',
].filter((dep) => !packageJson.dependencies[dep] && !packageJson.devDependencies[dep]);

const packagesToResolve = [
...controlsPeerDependencies,
...peerDependencies,
'@storybook/addon-ondevice-controls',
'@storybook/addon-ondevice-actions',
'@storybook/react-native',
Expand Down Expand Up @@ -57,7 +61,8 @@ const generator = async (
await copyTemplateFiles({
packageManager,
renderer: 'react-native',
language: SupportedLanguage.TYPESCRIPT_3_8,
// this value for language is not used since we only ship the ts template. This means we just fallback to @storybook/react-native/template/cli.
language: SupportedLanguage.TYPESCRIPT_4_9,
destination: storybookConfigFolder,
});
};
Expand Down
9 changes: 6 additions & 3 deletions code/lib/create-storybook/src/initiate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,13 @@ export async function doInitiate(options: CommandOptions): Promise<
${chalk.inverse(' ' + "export {default} from './.storybook';" + ' ')}
2. Enable transformer.unstable_allowRequireContext in your metro config
2. Wrap your metro config with the withStorybook enhancer function like this:
For a more detailed guide go to:
${chalk.cyan('https://github.com/storybookjs/react-native#existing-project')}
${chalk.inverse(' ' + "const withStorybook = require('@storybook/react-native/metro/withStorybook');" + ' ')}
${chalk.inverse(' ' + 'module.exports = withStorybook(defaultConfig);' + ' ')}
For more details go to:
${chalk.cyan('https://github.com/storybookjs/react-native#getting-started')}
Then to run your Storybook, type:
Expand Down

0 comments on commit b5af0c8

Please sign in to comment.