-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement "create admin session" capability #374
Conversation
TODO - [ ] add tests
also remove explicit JSDoc dep - I'm not sure why this doesn't work, but something about the way that type is being exported is freaking out our builder. probably needs to be resolved a different way, but I want to get my PR green before shaving that yak
View stack outputs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -5,9 +5,26 @@ import dotenv from 'dotenv' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be as follow up: would love to see part of this being actually tested via the interface exported tests so that it is easier to move from this repo to other implementations https://github.com/w3s-project/w3up/blob/main/packages/upload-api/test/handlers/plan.js
Implement plan/create-admin-session - see storacha/console#98 for an example of this in action.
Originally #358, moving here to unstick the integration tests.