Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement "create admin session" capability #374

Merged
merged 11 commits into from
May 21, 2024

Conversation

travis
Copy link
Member

@travis travis commented May 17, 2024

Implement plan/create-admin-session - see storacha/console#98 for an example of this in action.

Originally #358, moving here to unstick the integration tests.

travis added 10 commits April 25, 2024 16:49
also remove explicit JSDoc dep - I'm not sure why this doesn't work, but something about the way that type is being exported is freaking out our builder.

probably needs to be resolved a different way, but I want to get my PR green before shaving that yak
@travis travis changed the title feat: implement "create admin session" capability #358 feat: implement "create admin session" capability May 17, 2024
Copy link

seed-deploy bot commented May 17, 2024

View stack outputs

@seed-deploy seed-deploy bot temporarily deployed to pr374 May 20, 2024 17:51 Inactive
@travis travis requested review from alanshaw and vasco-santos May 20, 2024 18:57
Copy link
Contributor

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -5,9 +5,26 @@ import dotenv from 'dotenv'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be as follow up: would love to see part of this being actually tested via the interface exported tests so that it is easier to move from this repo to other implementations https://github.com/w3s-project/w3up/blob/main/packages/upload-api/test/handlers/plan.js

@travis travis merged commit 1fa4a98 into main May 21, 2024
3 checks passed
@travis travis deleted the feat/plan-create-admin-session branch May 21, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants