Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a toaster for notifications and other snacks #91

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

travis
Copy link
Member

@travis travis commented Feb 9, 2024

Use react-hot-toast to introduce "toaster" style notifications:

https://react-hot-toast.com/

These should be refined over time, but as an experiment I've introduced this on the "plan change" page and am using it to let the user know when something goes wrong:

Screen.Recording.2024-02-08.at.4.14.16.PM.mov

or when something goes right:

Screen.Recording.2024-02-08.at.4.21.52.PM.mov

If this seems like a good pattern to everyone I think we should start using it more broadly - no longer will our users be forced to watch a whole file upload just to get feedback about its success or failure!

Use `react-hot-toast` to introduce "toaster" style notifications:

https://react-hot-toast.com/

These should be refined over time, but as an experiment I've introduced this on the "plan change" page and am using it to let the user know when something goes wrong:

or when something goes right:
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Website preview 🔗✨

build log

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I left a comment - not too bothered by refactoring but I think we need to throw when there's an error in the result to signal to toaster that an error occurred.

@travis travis merged commit 1906d39 into main Apr 18, 2024
5 checks passed
@travis travis deleted the feat/plan-update-error branch April 18, 2024 18:01
joaosa pushed a commit that referenced this pull request Apr 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.6.0](w3console-v1.5.0...w3console-v1.6.0)
(2024-04-22)


### Features

* add a toaster for notifications and other snacks
([#91](#91))
([1906d39](1906d39))


### Bug Fixes

* allow release-please to release
([#97](#97))
([cebb599](cebb599))


### Other Changes

* migrate repo ([#96](#96))
([d79663c](d79663c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fforbeck pushed a commit to storacha/upload-service that referenced this pull request Feb 5, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.6.0](storacha/console@w3console-v1.5.0...w3console-v1.6.0)
(2024-04-22)


### Features

* add a toaster for notifications and other snacks
([#91](storacha/console#91))
([1906d39](storacha/console@1906d39))


### Bug Fixes

* allow release-please to release
([#97](storacha/console#97))
([cebb599](storacha/console@cebb599))


### Other Changes

* migrate repo ([#96](storacha/console#96))
([d79663c](storacha/console@d79663c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants