Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show QR code for share in information and creation modal #723

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Show QR code for share in information and creation modal #723

wants to merge 7 commits into from

Conversation

aarondoet
Copy link
Contributor

closes #244

example

@stonith404
Copy link
Owner

That's a nice addition, thanks. In my opinion it would be nice if the admin could enable or disable if QR codes should be shown. What do you think?

@aarondoet
Copy link
Contributor Author

I'd say this would rather be personal settings, not something the admin needs to set for everyone.

@stonith404
Copy link
Owner

Yeah you're right, that makes more sense.

stonith404
stonith404 requested changes Jan 14, 2025
View reviewed changes
Copy link
Owner

@stonith404 stonith404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about the user option but in my opinion it would make more sense to add a button next to the copy link button that shows the QR code when clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonith404 stonith404 stonith404 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: show QR code after upload, that links straight to the file
2 participants
@aarondoet @stonith404