Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plugin setup and remove initial credentials from code #48

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

daianmartinho
Copy link

Description

This PR:

  1. ensure plugin setup respect the list
  2. remove initial credentials from code

Motivation and Context

  1. Credentials are not supposed to be in code.
  2. Simplifies the plugin list. If the plugin is in the list, the role ensures that the plugin will be installed. If the plugin is not in the list, the role will ensure that the plugin is uninstalled. This make the code cleaner. This is the breaking change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant