Fix false positive detection #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PNGs or GIFs can currently be improperly detected as JPEGs, this fixes that: 1st it checks for mime on the blob 2nd it checks for data:image/jpeg for dataURLs 3rd it does a check for .jpg or .jpeg for provided string srcs Otherwise, any transparent PNGs or GIFs will also be detected as "squashed". Thanks for the great library!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNGs or GIFs can currently be improperly detected as JPEGs, this fixes that:
1st it checks for mime on the blob
2nd it checks for data:image/jpeg for dataURLs
3rd it does a check for .jpg or .jpeg for provided string srcs
Otherwise, any transparent PNGs or GIFs will also be detected as "squashed".
Thanks for the great library!