-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACM Obs bot] Bump stolostron/prometheus to v2.53.1 #69
[ACM Obs bot] Bump stolostron/prometheus to v2.53.1 #69
Conversation
Signed-off-by: Mickael Carl <[email protected]>
Signed-off-by: Mickael Carl <[email protected]>
Signed-off-by: tyltr <[email protected]>
… strconv.FormatInt() with better performance should be used. Signed-off-by: roger.wang <[email protected]>
This is the time period covered by a batch of samples, when the number of waiting samples is lower than max_samples_per_send. It does not affect timeouts or retries. Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Federico Leva <[email protected]>
…d for transient file writes. use it in loadDataAsQueryable to make sure the RO Head doesn't truncate or cut new chunks in data/chunks_head/. add a -sandbox-dir-root flag to "promtool tsdb dump/dump-openmetrics" to control the root of that sandbox dirrectory. Signed-off-by: machine424 <[email protected]>
Signed-off-by: komisan19 <[email protected]>
Signed-off-by: komisan19 <[email protected]>
…re restore time per rule group When a rule group changes or prometheus is restarted we need to ensure we restore the active alerts that were firing for a corresponding rule, for that Prometheus uses the `ALERTS_FOR_STATE` series to query the previous state and restore it. If a given rule has high cardinality (think 100s of 1000s for series) this proccess can take a bit of time - this is the first of a series of PRs to improve this problem and I'd like to start with exposing the time it takes to restore a rule group as a gauge. Signed-off-by: gotjosh <[email protected]>
Signed-off-by: tesla59 <[email protected]>
… log line to record total time Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
…rometheus#13958) * Avoid creating new slices for labels values on postings for matchers Signed-off-by: alanprot <[email protected]> * refactor Signed-off-by: alanprot <[email protected]> --------- Signed-off-by: alanprot <[email protected]>
…ime-rules Rule Manager: Add `rule_group_last_restore_duration_seconds` to measure restore time per rule group
Prometheus restores alert state between restarts and updates. For each rule, it looks at the alerts that are meant to be active and then queries the `ALERTS_FOR_STATE` series for _each_ alert within the rules. If the alert rule has 120 instances (or series) it'll execute the same query with slightly different labels. This PR changes the approach so that we only query once per alert rule and then match the corresponding alert that we're about to restore against the series-set. While the approach might use a bit more memory at start-up (if even?) the restore proccess is only ran once per restart so I'd consider this a big win. This builds on top of prometheus#13974 Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
- Improve variable name of the map produced by the series set Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Signed-off-by: gotjosh <[email protected]>
Up until this point, if a scrape was done with the protobuf format Prometheus would always try to ingest native histograms even with the feature flag disabled. This causes problems with other feature-flags that depend on the protobuf format, like 'created-timestamp-zero-ingestion'. This commit decouples native histogram parsing from ingestion, making sure ingestion only happens when the 'native-histogram' feature-flag is enabled. Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: George Robinson <[email protected]>
…gestion bugfix: Decouple native histogram ingestions and protobuf parsing
Previously the metrics adapters for client-go were registered in an init function. This resulted in clobbering default metrics providers when these packages are imported into an application that leverages the default client-go metrics registry. Instead, let's only register these adapters when requested. Signed-off-by: Stephen Heckler <[email protected]>
Co-authored-by: Ayoub Mrini <[email protected]> Signed-off-by: Nishant Singh <[email protected]>
Co-authored-by: Ayoub Mrini <[email protected]> Signed-off-by: Nishant Singh <[email protected]>
…#13941) * fix(scaleway-sd): use public IPs if no private IP present * tests(scaleway-sd): add instance with routed public ip and no private ip --------- Signed-off-by: Heyoxe <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Co-authored-by: Julien <[email protected]> Signed-off-by: George Krajcsovits <[email protected]>
…lease Prepare 2.53.0 release
…catch-up (prometheus#14446) * Revert "fix bug that would cause us to endlessly fall behind (prometheus#13583)" This reverts commit 0c71230. (leaving the new test in place) * TSDB: enhance TestRun_AvoidNotifyWhenBehind With code suggested by @cstyan in prometheus#14439. * WAL watcher: add back log line showing current segment --------- Signed-off-by: Bryan Boreham <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]> Signed-off-by: Bryan Boreham <[email protected]>
80d3f40
to
288a9a8
Compare
Hi @acm-observability-bot[bot]. Thanks for your PR. I'm waiting for a stolostron member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c1c8549
to
ca8387b
Compare
/ok-to-test |
241708d
to
5d91914
Compare
v2.53.1 # -----BEGIN SSH SIGNATURE----- # U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgX42TrpDUXJbbi9yZ3hs6cDg+kz # G6d3nAlAb2XQInrEgAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 # AAAAQJR0Qy5yvoOAtyPRnyZSD7u7b55VVE1xSdLMTwrzKs0ZGspBKawghW9OTVsKijRfGZ # uLbIjC5739NuBTk9E1bAE= # -----END SSH SIGNATURE----- # gpg verification failed.
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5d91914
to
2938cc2
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@acm-observability-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acm-observability-bot[bot], philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1cfecf6
into
stolostron:release-2.12
Description
This is an automated version bump from CI.
The logs for this run can be found in the syncbot repo actions.
If you wish to perform this manually, execute the following commands from stolostron/prometheus repo: