Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace master with 3.14 #189

Closed
wants to merge 256 commits into from
Closed

Replace master with 3.14 #189

wants to merge 256 commits into from

Conversation

yiraeChristineKim
Copy link

No description provided.

davis-haba and others added 30 commits November 24, 2023 16:17
* Implement AssignImage mutator
Signed-off-by: davis-haba <[email protected]>

* fix tests
Signed-off-by: davis-haba <[email protected]>

* fix controller gen setup
Signed-off-by: davis-haba <[email protected]>

* fix helm manifest generation
Signed-off-by: davis-haba <[email protected]>

* WIP assignimage byPod status
Signed-off-by: davis-haba <[email protected]>

* mutator pod status working for assignimage
Signed-off-by: davis-haba <[email protected]>

* e2e test assignimage mutator deleted
Signed-off-by: davis-haba <[email protected]>

* old kubectl run
Signed-off-by: davis-haba <[email protected]>

* address comments. domain must have '.' unless localhost
Signed-off-by: davis-haba <[email protected]>

* appease linter
Signed-off-by: davis-haba <[email protected]>

* fix gator tests
Signed-off-by: davis-haba <[email protected]>

* add test domain ending in colon still converges
Signed-off-by: davis-haba <[email protected]>

* docs for assignimage
Signed-off-by: davis-haba <[email protected]>

* remove newline
Signed-off-by: davis-haba <[email protected]>

* address comments
Signed-off-by: davis-haba <[email protected]>

* appease linter
Signed-off-by: davis-haba <[email protected]>

* cleanup dead code branch
Signed-off-by: davis-haba <[email protected]>

* validateDomain to use splitDomain
Signed-off-by: davis-haba <[email protected]>

* future-proof validateImageParts. Add custom error types.
Signed-off-by: davis-haba <[email protected]>

* fix readiness tracker test
Signed-off-by: davis-haba <[email protected]>

* make manifests
Signed-off-by: davis-haba <[email protected]>

* validate that splitting a valid tag never returns a path
Signed-off-by: davis-haba <[email protected]>

* degenerate cases for unit tests. do not expose regex on image component error.
Signed-off-by: davis-haba <[email protected]>

* test missing image field. update error copy.
Signed-off-by: davis-haba <[email protected]>

* tag error copy
Signed-off-by: davis-haba <[email protected]>

* Update pkg/expansion/system_test.go

Co-authored-by: Rita Zhang <[email protected]>
Signed-off-by: Davis Haba <[email protected]>

* Update pkg/mutation/mutators/assignimage/assignimage_mutator.go

Co-authored-by: Rita Zhang <[email protected]>
Signed-off-by: Davis Haba <[email protected]>

* errors.As instead of type casting in unit tests
Signed-off-by: davis-haba <[email protected]>

* fix error type checking
Signed-off-by: davis-haba <[email protected]>

Signed-off-by: Davis Haba <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
Co-authored-by: Rita Zhang <[email protected]>
…y-agent#2530)

* Upgrade to k8s v0.26.1 and controller-runtime fork

Signed-off-by: Max Smythe <[email protected]>

* Re-add stop channel to informer map entry

Signed-off-by: Max Smythe <[email protected]>

* Update linter version

Signed-off-by: Max Smythe <[email protected]>

* Fix lint errors

Signed-off-by: Max Smythe <[email protected]>

* Fix broken tests

Signed-off-by: Max Smythe <[email protected]>

* Fix function docstring

Signed-off-by: Max Smythe <[email protected]>

* Fix gofumpt violation

Signed-off-by: Max Smythe <[email protected]>

Signed-off-by: Max Smythe <[email protected]>
…-agent#2536)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <[email protected]>
…cy-agent#2535)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <[email protected]>
…ent#2543)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2547)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2546)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add --operation=mutation-controller flag
Signed-off-by: davis-haba <[email protected]>

* operations in sorted order
Signed-off-by: davis-haba <[email protected]>

* update mutation-controller op docs to indicate audit may also need the
flag
Signed-off-by: davis-haba <[email protected]>

---------

Co-authored-by: Sertaç Özercan <[email protected]>
…cy-agent#2545)

Introduce gci to unify the order of package import

Signed-off-by: Fish-pro <[email protected]>
Co-authored-by: Rita Zhang <[email protected]>
…nt#2581)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…licy-agent#2566)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2565)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
open-policy-agent#2567)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#2568)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
acpana and others added 16 commits November 24, 2023 16:19
…#3060)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n-policy-agent#3070)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…olicy-agent#3069)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <[email protected]>
…ck for 3.14 (open-policy-agent#3141)

Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: alex <[email protected]>
Signed-off-by: Sertaç Özercan <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: sozercan <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: mprahl <[email protected]>
Co-authored-by: mprahl <[email protected]>
Signed-off-by: Yi Rae Kim <[email protected]>
ref: https://issues.redhat.com/browse/ACM-6233

Signed-off-by: Dale Haiducek <[email protected]>
Co-authored-by: Dale Haiducek <[email protected]>
Signed-off-by: Yi Rae Kim <[email protected]>
Copy link

openshift-ci bot commented Nov 24, 2023

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot requested review from dhaiducek and gparvin November 24, 2023 21:23
Copy link

openshift-ci bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 24, 2023

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the stolostron org. You can then trigger verification by writing /verify-owners in a comment.

  • JoelSpeed
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • sbueringer
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • testing-integration-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • controller-runtime-admins
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/OWNERS
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-reviewers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-approvers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/OWNERS
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • controller-runtime-maintainers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS
  • schrej
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
    • third_party/sigs.k8s.io/controller-runtime/pkg/envtest/komega/OWNERS

@dhaiducek
Copy link

I'm assuming this is bringing the master branch up-to-date? I mentioned keeping the branches in sync to @mprahl the other day. We'll have to figure out a process for this. @mprahl was of the opinion that this master and upstream should be 100% in sync. If we do that, we can set up a periodic fast-forward from upstream to here and then somehow calculate and automate which changes we need cherry-picked (like TLS, CGO, etc) each time we cut our own release.

@yiraeChristineKim
Copy link
Author

@dhaiducek Thanks Dale!!

@mprahl
Copy link

mprahl commented Nov 27, 2023

@yiraeChristineKim , could you please describe the purpose of this PR a bit?

@yiraeChristineKim
Copy link
Author

@mprahl sync master with v3.14.0 I guess this is a wrong way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.