Skip to content

add travis-ci and bors config #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 6, 2019
Merged

add travis-ci and bors config #15

merged 13 commits into from
Jul 6, 2019

Conversation

jordens
Copy link
Member

@jordens jordens commented Jul 3, 2019

Once a new stm32-rs 0.8 with the current pending breaking stm32h7 changes is released (#5) the hack to locally build and use that crate can be removed.
Stable/beta builds will only succeed once #6 is resolved.

I would still suggest merging this as it already exposes, e.g. https://travis-ci.com/stm32-rs/stm32h7xx-hal/jobs/213079743#L354-L408

None of this will succeed until #5 is resolved.

Stable builds will only succeed once #6 is resolved.
@richardeoin
Copy link
Member

Great, looking forward to having this working

@astraw astraw removed their request for review July 4, 2019 04:43
Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I definitely support warnings-as-errors for a library crate such as this.

@jordens jordens merged commit fb5f16e into master Jul 6, 2019
@jordens jordens deleted the travis-bors branch July 11, 2019 17:22
mtthw-meyer pushed a commit to mtthw-meyer/stm32h7xx-hal that referenced this pull request Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants