Skip to content

Fix SPI3 alternate function remapping. #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

AndreySmirnov81
Copy link
Contributor

@AndreySmirnov81 AndreySmirnov81 commented Feb 26, 2021

AndreySmirnov81 referenced this pull request Feb 26, 2021
This is necessary in order for SPI3 to function correctly.

Note that this is a breaking change, as it requires access to `MAPR` via
a new argument. This has been added as the third argument to match the
`spi1` constructor.

Tested successfully on an F107.
@AndreySmirnov81
Copy link
Contributor Author

@burrbull, please tell me what else I need to do to complete the pull request?

@burrbull
Copy link
Member

@burrbull, please tell me what else I need to do to complete the pull request?

I don't have write access to this repo.
cc @TheZoq2 @therealprof

@TheZoq2
Copy link
Member

TheZoq2 commented Mar 14, 2021

Thanks for the PR and sorry for the delay. Looks great!

Regarding write access: @burrbull I wouldn't mind giving you write access if you're interested. As you may have noticed, I've had less time/energy to deal with PRs here and it would be great to have some help with that :)

@TheZoq2 TheZoq2 merged commit 01482ef into stm32-rs:master Mar 14, 2021
@burrbull burrbull mentioned this pull request Aug 4, 2021
@AndreySmirnov81 AndreySmirnov81 deleted the master branch February 8, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no method named spi3_remap found
3 participants