Bump GCC version used in CI. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning in cow_test.cpp needed to be supressed. See stlab#438
nickpdemarco
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Approved - but for my education, can you explain why we're suppressing the warning? I looked at #438 and didn't see a reason why it's a false positive.
|
It could be an actual bug. The suppression was introduced to decouple two efforts: solving the autoconf problems, and fixing issues identified by new GCC 11 warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning in cow_test.cpp needed to be supressed. See #438