Minimizing the clang-tidy exception list #29
Conversation
.clang-tidy
Outdated
|
|
||
| WarningsAsErrors: '' |
There was a problem hiding this comment.
Ideally we wouldn't be making semantically meaningless changes. Is all the quotation mark and whitespace conversion coming from your personal tool? If so I guess we should revert it.
They seem to account for 95% of the changes in this file.
CMakeLists.txt
Outdated
| @@ -57,7 +57,6 @@ add_library(adobe_contract_checking::adobe_contract_checking_warnings ALIAS adob | |||
| add_subdirectory(configured_files) | |||
|
|
|||
| # Adding the src: | |||
| add_subdirectory(src) | |||
There was a problem hiding this comment.
Why is this part of this PR?
There was a problem hiding this comment.
Did you intend to use a different base commit for the PR?
include/adobe/contract_checks.hpp
Outdated
| */ | ||
|
|
||
| /**************************************************************************************************/ | ||
|
|
There was a problem hiding this comment.
Maybe this is being overly-pedantic, but… separate PR?
CMakeLists.txt
Outdated
| @@ -94,7 +93,6 @@ endif() | |||
|
|
|||
| if(BUILD_TESTING) | |||
| include(CTest) | |||
| message(AUTHOR_WARNING "Building Tests. Be sure to check out test/constexpr_tests.cpp for constexpr testing") | |||
There was a problem hiding this comment.
Shouldn't be in this PR.
Dependencies.cmake
Outdated
| @@ -4,6 +4,7 @@ if(BUILD_TESTING) | |||
| FetchContent_Declare( | |||
| googletest | |||
| URL https://github.com/google/googletest/archive/ff233bdd4cac0a0bf6e5cd45bda3406814cb2796.zip | |||
| DOWNLOAD_EXTRACT_TIMESTAMP "ON" | |||
There was a problem hiding this comment.
Shouldn't be part of this PR
ProjectOptions.cmake
Outdated
| @@ -1,5 +1,4 @@ | |||
| include(cmake/SystemLink.cmake) | |||
| include(cmake/LibFuzzer.cmake) | |||
There was a problem hiding this comment.
Changes to this file shouldn't be part of this PR
README.md
Outdated
| @@ -1,42 +1,42 @@ | |||
| [](https://github.com/stlab/adobe-contract-checks/actions/workflows/ci.yml) | |||
| [](https://github.com/stlab/adobe-contract-checks/actions/workflows/codeql-analysis.yml) | |||
|
|
|||
| ------ | |||
There was a problem hiding this comment.
Changes to this file shouldn't be part of this PR. Meaningless format changes especially.
|
The most ideal situation for clients would be to enable ALL clang-tidy checks and then disable them with inline comments as needed. Maybe that's just ridiculous; I don't know. The C++ include model is so broken; I don't know what library authors are expected to do about this. |
|
I think you're looking at the changes from main? Some of your comments are regarding the branch this is based on. |
|
I'm not sure how to review this if you only mean a fraction of the changes that are shown to be reviewed. This PR has 14 commits. At this point, if I were working on this, I would not be trying to preserve any history; I would make a new PR starting from |
…tlab/adobe-contract-checks into sean-parent/clang-tidy-cleanup
Enabled all clang-tidy checks except: