Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: port remaining in-lined scripts to scripts/ #216

Merged
merged 23 commits into from
Feb 12, 2025
Merged

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented Feb 12, 2025

Describe the problem or feature in addition to a link to the issues.

Fixes #214

Also adds a new Docker convention that scripts copied from scripts/ should use the same path within the image (e.g. scripts/star/sort_star_input.py should be copied to and called as /scripts/star/sort_star_input.py)

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • The code passes all CI tests without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in any relevant CHANGELOGs (when appropriate).
  • If you have made any changes to the scripts/ or docker/ directories, please ensure any image versions have been incremented accordingly!
  • You have updated the README or other documentation to account for these changes (when appropriate).

@a-frantz a-frantz changed the title WIP chore: port remaining in-lined scripts to scripts/ Feb 12, 2025
@a-frantz a-frantz self-assigned this Feb 12, 2025
@a-frantz a-frantz requested a review from adthrasher February 12, 2025 15:43
adthrasher
adthrasher previously approved these changes Feb 12, 2025
@a-frantz a-frantz requested a review from adthrasher February 12, 2025 21:51
@a-frantz a-frantz marked this pull request as ready for review February 12, 2025 21:51
@a-frantz a-frantz merged commit 5dc9fd0 into main Feb 12, 2025
36 of 43 checks passed
@a-frantz a-frantz deleted the chore/scripts branch February 12, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finish porting in-lined scripts to the new scripts/ dir
2 participants