Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi-C workflow #139

Open
wants to merge 149 commits into
base: main
Choose a base branch
from
Open

Hi-C workflow #139

wants to merge 149 commits into from

Conversation

adthrasher
Copy link
Member

@adthrasher adthrasher commented Mar 22, 2024

Implements a workflow to generate a bowtie2-aligned BAM and a .hic file for analysis. This utilizes the commonly used HiC-Pro workflow.

@adthrasher adthrasher self-assigned this Mar 22, 2024
@adthrasher adthrasher mentioned this pull request Apr 29, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snyk Container found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@adthrasher adthrasher requested a review from a-frantz February 7, 2025 15:34
tests/tools/test_picard.yaml Outdated Show resolved Hide resolved
tests/tools/test_picard.yaml Outdated Show resolved Hide resolved
tests/tools/test_samtools.yaml Outdated Show resolved Hide resolved
tools/hilow.wdl Outdated Show resolved Hide resolved
tools/hilow.wdl Outdated Show resolved Hide resolved
workflows/general/fastq-to-ubam.wdl Show resolved Hide resolved
Comment on lines +6 to +7
"make_hic_reference.restriction_sites": ["^GATC", "^GATC", "A^GATCT", "A^AGCTT", "G^ANTC", "AT^CGAT"],
"make_hic_reference.restriction_sites_names": ["mboi", "dpnii", "bglii", "hindiii", "hinfi", "clai"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be moved to the defaults of the workflow? In what situations would a user want to use something different?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restriction sites are custom to the experiment. I put several of the most common ones here, but there's no reason someone couldn't be using a different cut site.

@@ -0,0 +1,9 @@
FROM ghcr.io/stjudecloud/bedtools:branch-hic_workflow-2.31.1-0 AS bedtools

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-13176 vulnerability in openssl Note

This file introduces a vulnerable openssl package with a low severity vulnerability.
@@ -0,0 +1,19 @@
FROM ubuntu:22.04 AS builder

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-13176 vulnerability in openssl Note

This file introduces a vulnerable openssl package with a low severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check failure

Code scanning / Snyk Container

Critical severity - Integer Overflow or Wraparound vulnerability in expat Critical

This file introduces a vulnerable expat package with a critical severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check failure

Code scanning / Snyk Container

Critical severity - Integer Overflow or Wraparound vulnerability in expat Critical

This file introduces a vulnerable expat package with a critical severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check failure

Code scanning / Snyk Container

High severity - XML External Entity (XXE) Injection vulnerability in expat High

This file introduces a vulnerable expat package with a high severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-50602 vulnerability in expat Note

This file introduces a vulnerable expat package with a low severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check warning

Code scanning / Snyk Container

Medium severity - Algorithmic Complexity vulnerability in libtasn1 Medium

This file introduces a vulnerable libtasn1 package with a medium severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-6119 vulnerability in openssl Note

This file introduces a vulnerable openssl package with a low severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-9143 vulnerability in openssl Note

This file introduces a vulnerable openssl package with a low severity vulnerability.
@@ -0,0 +1,15 @@
FROM aidenlab/juicer:v2.0.1 AS builder

Check notice

Code scanning / Snyk Container

Low severity - CVE-2024-13176 vulnerability in openssl Note

This file introduces a vulnerable openssl package with a low severity vulnerability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants