feat: implement mount points for task execution. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the calculation of mount points for task execution backends that use containers. Paths from `File` and `Directory` values that are visible prior to evaluating the command section of a task are added to a `PathTrie`. The `PathTrie` is used to determine the minimum number of mounts in the guest environment to be able to send input files to the container. Command evaluation does a translation from host paths to guest paths so that the generated command script uses only guest paths. Similarly, evaluation of output values does a translation from guest paths to host paths so that tasks always output the host path. Fixes stjude-rust-labs#267.
|
I forgot to mention that I need to test that new unit test on Windows as the paths obviously are for unix, so I expected the Windows CI to fail; I'll get a similar test implemented to test Windows paths. |
a-frantz
reviewed
Feb 6, 2025
* Rename `path2` to `path`. * Add a `MountPoint` struct to replace the tuple in areas to make it less confusing as to the contents of a mount point.
a-frantz
approved these changes
Feb 7, 2025
Co-authored-by: Andrew Frantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the calculation of mount points for task execution backends that use containers.
Paths from
FileandDirectoryvalues that are visible prior to evaluating the command section of a task are added to aPathTrie.The
PathTrieis used to determine the minimum number of mounts in the guest environment to be able to send input files to the container.Command evaluation does a translation from host paths to guest paths so that the generated command script uses only guest paths.
Similarly, evaluation of output values does a translation from guest paths to host paths so that tasks always output the host path.
Fixes #267.
Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).