Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAF and RDF computation #174

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add VAF and RDF computation #174

merged 1 commit into from
Jun 7, 2024

Conversation

oerc0122
Copy link
Collaborator

Enable VAF and RDF computation following MD runs and independently through the Python interfaces.

Partially addresses #117.

@oerc0122 oerc0122 added the enhancement New/improved feature or request label May 31, 2024
@oerc0122 oerc0122 self-assigned this May 31, 2024
@oerc0122 oerc0122 force-pushed the add-post-process branch 2 times, most recently from bc0dfd8 to 5a94927 Compare May 31, 2024 13:26
tests/test_md.py Outdated Show resolved Hide resolved
janus_core/calculations/md.py Outdated Show resolved Hide resolved
janus_core/calculations/md.py Outdated Show resolved Hide resolved
janus_core/helpers/post_process.py Outdated Show resolved Hide resolved
janus_core/helpers/post_process.py Outdated Show resolved Hide resolved
janus_core/calculations/md.py Outdated Show resolved Hide resolved
janus_core/calculations/md.py Outdated Show resolved Hide resolved
janus_core/helpers/post_process.py Outdated Show resolved Hide resolved
@oerc0122 oerc0122 force-pushed the add-post-process branch 3 times, most recently from 0a0b056 to 062e09c Compare June 5, 2024 11:02
@oerc0122 oerc0122 force-pushed the add-post-process branch 3 times, most recently from 3ca8710 to c27e21c Compare June 5, 2024 11:37
Copy link
Member

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a test for the MD CLI with some form of post processing?

tests/test_md.py Outdated Show resolved Hide resolved
janus_core/calculations/md.py Show resolved Hide resolved
janus_core/calculations/md.py Outdated Show resolved Hide resolved
@oerc0122 oerc0122 force-pushed the add-post-process branch 2 times, most recently from e5a526a to dc24512 Compare June 6, 2024 14:01
alinelena
alinelena previously approved these changes Jun 6, 2024
@alinelena alinelena self-requested a review June 7, 2024 13:37
@alinelena alinelena merged commit e3d6696 into main Jun 7, 2024
16 checks passed
@ElliottKasoar ElliottKasoar deleted the add-post-process branch June 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New/improved feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants