Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_callee() which determines the right routine of the return values of get_callees() #2775

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,13 @@
*~
*.a
*.o
*.psycache
gnu_opt_report.txt
*.mod
*.MOD
.cache
.coverage
*.swp
doc/*/_build
doc/*/*/_build
doc/reference_guide/source/autogenerated/
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ cloning this repository and using:

$ pip install .

or in developer (editable) mode using

$ pip install -e .

For more information about the installation process see
[this section of the User Guide](https://psyclone.readthedocs.io/en/latest/system_specific_setup.html).

Expand Down
6 changes: 3 additions & 3 deletions doc/developer_guide/system_specific_setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ Installing Documentation Tools
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Install Sphinx along with bibtex support for creating PSyclone documentation::

> sudo pip install sphinx sphinxcontrib.bibtex
> pip install .[doc]

You can now build html documentation::
You can now build html documentation. E.g., for the developer documentation::

> cd doc
> cd doc/developer_guide/
> make html

The latex package is required to create the pdf documentation
Expand Down
23 changes: 23 additions & 0 deletions doc/developer_guide/working_practises.rst
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,29 @@ Additionally html output can be created by adding the option ``--cov-report html
The html output can be viewed with a browser at ``file:///.../tests/htmlcov/index.html``
and it highlights all source lines in red that are not covered by at least one test.

For convenience, there is also a script in ``<PSYCLONEHOME>/utils/run_pytest_cov.sh``
running the coverage tests for all relevant files.
This also creates a ``cov.xml`` file which can be used by, e.g., vscode.
See the respective comments in this script for further information.


.. _flake8:

Flake8
------------------

Flake8 is a program testing for good coding styles.
It can be installed with::

> pip install flake8

and executed with::

> flake8 src/psyclone

For convenience, this is also available in ``utils/run_flake8.sh``.
This script can be also used as a git pre-push hooks by linking this file to ``.git/hooks/pre-push``.

.. _parallel_execution:

Parallel execution
Expand Down
2 changes: 1 addition & 1 deletion src/psyclone/psyir/frontend/fparser2.py
Original file line number Diff line number Diff line change
Expand Up @@ -2060,7 +2060,7 @@ def _get_partial_datatype(self, node, scope, visibility_map):
orig_entity_decl_children = list(entity_decl.children[:])

# 2: Remove any unsupported attributes
unsupported_attribute_names = ["pointer", "target"]
unsupported_attribute_names = ["pointer", "target", "optional"]
attr_spec_list = node.children[1]
orig_node_children = list(node.children[:])
orig_attr_spec_list_children = (list(node.children[1].children[:])
Expand Down
Loading
Loading