Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Closes #2755) Bug fix for psyad failing to transform array assignment #2767

Merged
merged 9 commits into from
Nov 19, 2024

Conversation

arporter
Copy link
Member

@arporter arporter commented Nov 5, 2024

A small change that (pleasingly) only involved me updating some code to remove an old restriction. @DrTVockerodtMO please could you try this branch and let me know whether it solves your problem?

@arporter arporter marked this pull request as draft November 5, 2024 14:18
@arporter arporter added bug Release Planning and creating PSyclone releases adjoint labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (a33a99b) to head (fbd511f).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2767   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         356      356           
  Lines       49479    49480    +1     
=======================================
+ Hits        49421    49422    +1     
  Misses         58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@arporter arporter marked this pull request as ready for review November 5, 2024 14:50
@arporter
Copy link
Member Author

arporter commented Nov 5, 2024

This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review.

@DrTVockerodtMO
Copy link
Collaborator

This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review.

Will be happy to, just need to figure out how to test specific branches on our system and I'll have a look!

@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

@DrTVockerodtMO and I have jointly test this branch against some kernels and everything looks OK. This is therefore ready for review. It's not a big change. Could be one for @hiker, @sergisiso, @LonelyCat124

@arporter
Copy link
Member Author

arporter commented Nov 8, 2024

I've just set the integration tests going.

Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment issues, and the need to bring it up to master.

src/psyclone/psyad/transformations/preprocess.py Outdated Show resolved Hide resolved
@arporter
Copy link
Member Author

Somehow, some warnings related to the Dev Guide had made it onto master and were causing the link check to fail. I've fixed those here so that the CI is green.

@arporter
Copy link
Member Author

This should be ready for another look now @hiker.

@arporter
Copy link
Member Author

The doc build is still failing but that's because the link to the OpenCL standard is returning a 403. If I visit the URL I get a check that I am a human so presumably this is what the problem is.

Copy link
Collaborator

@hiker hiker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. I've triggered the CI (because of changes to array_mixin), and will continue to merge if this is successful.

src/psyclone/psyad/transformations/preprocess.py Outdated Show resolved Hide resolved
@arporter
Copy link
Member Author

arporter commented Nov 18, 2024

Hi @hiker, note that the integration-test failure for NEMO5 is expected (@sergisiso says he's broken something).

@hiker
Copy link
Collaborator

hiker commented Nov 18, 2024

Assuming that the NEMO failures are known (as indicated by Andy), and the link check is also unrelated, I progress with merging.

@hiker hiker merged commit 816177c into master Nov 19, 2024
12 of 13 checks passed
@hiker hiker deleted the 2755_psyad_array_notn_bug branch November 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adjoint bug Release Planning and creating PSyclone releases under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants