Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1991 better compilation support #2026

Merged
merged 94 commits into from
May 2, 2023
Merged

1991 better compilation support #2026

merged 94 commits into from
May 2, 2023

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Jan 24, 2023

Adds support to inline all required dependencies that can be found using a ModuleManager.

@hiker
#1991 Added first WIP version of inlining all required modules.
ff2acdf
@hiker
#1991 Updated example to support inlined modules.
122bb52
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
b1fe078 
…1_better_compilation_support
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
3f9896b 
…1_better_compilation_support
@hiker
#1991 Renamed module information to module manager, moved it to the p…
4db5602 
…arse directory.
@hiker
#1991 Made the module manager a singleton.
a3abce0
@hiker
#1991 Make the ModuleManager work with search directories instead of …
316f6eb 
…a list of all files.
@hiker
#1991 Added tests and make sure to cover all lines.
db4c96a
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
ad6a5ae 
…1_better_compilation_support
@hiker
#1991 Use os.access isntead of exists, which is a stricter test.
c2ea7b0
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
f7d3517 
…1_better_compilation_support
@hiker
#1991 Fixed handling of modules that are not found.
6ec0ba3
@hiker
#1991 Added missing docstring.
6baceaa
@hiker
#1991 Started to add a new ModuleInfo object to better encapsulate ca…
fcc2fd8 
…ching of module information.
@hiker
#1991 Moved parse tree handling to module info.
788ddb3
@hiker
#1991 Moved used module detection into ModuleInformation.
6eb10d7
@hiker
#1991 Split ModuleManager and ModuleInformation into two files.
cff0173
@hiker
#1991 Split the module manager tests into two files, each one testing…
b901548 
… the newly split modules.
@hiker
#1991 Moved recursive collection of dependencies into module manager,…
9c98768 
… added ModuleInfoError class, some code cleanup.
@hiker
#1991 Make the module dependency function a static method in the Modu…
0dd95be 
…leManager.
@hiker
#1991 Simplified search loop.
6bc09ce
@hiker
#1991 Fixed test to handle empty modules as expected.
23fdc4a
@hiker
#1991 Updated driver tests to work with the .F90 file extension.
722b408
@hiker
#1991 Removed old precision handling in driver creation which is not …
78941b8 
…needed anymore due to inlining of constants.mod.
@hiker
#1991 Added r_second which is required for gungho.
121c88d
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
805bd51 
…1_better_compilation_support
@hiker
Merge branch '1483_lfric_extraction_driver-test-merge-psyir' into 199…
c042a20 
…1_better_compilation_support
@hiker
#1991 Add l_def to the list of imported symbols.
6f618ce
@hiker
#1991 Use 2008 Fortran standard, not 2003.
7a43fc8
@hiker
#1991 Fixed handling of invalid paths as -d command line parameter, t…
5d29837 
…o use the old handling which gives more specific error messages, and fixes a failing test.
@hiker
Copy link
Collaborator Author

hiker commented Apr 27, 2023

Ready for next review. I am aware I added a few questions to discuss which way you want to go in some cases.

arporter
arporter requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nearly there now.
Tests and examples are still all OK with compilation.
Ref. guide builds with no new warnings.

src/psyclone/tests/test_files/dynamo0p3/infrastructure/README.md Show resolved Hide resolved
arporter
arporter approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Joerg, all good now.
Tests and examples are still fine with compilation.
Ref. guide still builds OK.
Will proceed to merge.

@arporter arporter merged commit 129e691 into master May 2, 2023
@arporter arporter deleted the 1991_better_compilation_support branch May 2, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arporter arporter arporter approved these changes

Assignees
No one assigned
Labels
enhancement LFRic Issue relates to the LFRic domain ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiker @arporter