Aab #9
Open
Aab #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавил возможность загрузки aab файла, но сам не тестировал |
Open
|
Добавил возможность выгрузить Что нового? в черновик (путь можно указать тот же что и для google play) |
Open
|
Привет |
|
Привет, спасибо за апдейт, постараюсь на этой или следующей неделях проверить и запаблишить обнову |
kindapath
reviewed
Nov 7, 2024
| draft_id = Helper::RustoreHelper.create_draft(token, package_name, publish_type, changelog_path) | ||
| # Загрузка aab | ||
| if aab | ||
| Helper::RustoreHelper.upload_app(token, draft_id, false, gms_apk, package_name, true) |
There was a problem hiding this comment.
Привет!
А вот тут не так должно быть случайно?
А то получается, if aab а мы все равно загружаем apk
Helper::RustoreHelper.upload_app(token, draft_id, false, aab, package_name, true)
There was a problem hiding this comment.
я бы вообще сделал отдельный апи для загрузки apk, aab, huawei_apk
меньше if'ов - проще код
да и у хуавея свой app gallery есть
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.