Update js_bridge.js #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we transmit parameters that contain space we need to encode uri
stewartpark
reviewed
Nov 17, 2018
There was a problem hiding this comment.
Not sure if encoding the whole URL at the end would have any downsides, compared to this previous PR(left undone, but tries to encode each component). Do you have any thoughts on this?
The test failure is unrelated to the change, it'll be fixed if you rebase. Once the test passes and the comment addressed, I'll get this one merged and create a new release.
Thanks for the contribution!
| @@ -80,7 +80,7 @@ var {{ namespace }} = new(function () { | |||
| if (is_absolute) { | |||
| return scheme + "://" + location.host + url; | |||
There was a problem hiding this comment.
Should we also encode this as well?
|
Fixes #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we pass parameters containing space it needs to encode url otherwise we get errors