Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image support #158

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

daaru00
Copy link

@daaru00 daaru00 commented Aug 14, 2019

I added a Dockerfile in order to build a Docker image to easily run this tool without installing or using it locally (that require PHP).

Documentation and example report an example of possible Docker image name steverobbins/magescan but, obviously, can be changed as you prefer.

In order to build this image you can run something like this:

docker build . -t steverobbins/magescan:latest --build-arg "RELEASE_VERSION=1.12.9"
docker push steverobbins/magescan:latest

where "RELEASE_VERSION=1.12.9" contain the released version to install inside the image and :latest is the Docker image tag. A better tag/version organization can be something like this:

docker build . -t steverobbins/magescan:1.12.9 --build-arg "RELEASE_VERSION=1.12.9"
docker push steverobbins/magescan:1.12.9
docker build . -t steverobbins/magescan:1.12.8 --build-arg "RELEASE_VERSION=1.12.8"
docker push steverobbins/magescan:1.12.8

and so on..

@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

Merging #158 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #158   +/-   ##
=======================================
  Coverage   54.52%   54.52%           
=======================================
  Files          27       27           
  Lines         829      829           
=======================================
  Hits          452      452           
  Misses        377      377

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e00c644...3089dde. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants