Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This fixes #1203 for links only #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

This fixes #1203 for links only #1204

wants to merge 2 commits into from

Conversation

robbie-cahill
Copy link

No description provided.

@robbie-cahill robbie-cahill mentioned this pull request May 23, 2018
Open
@kchrismc
Copy link

kchrismc commented Aug 28, 2018 •
edited
Loading

This fix leads to an error when trying to swipe between images in a gallery with touch.

Error: Cannot read property 'href' of undefined

e.srcElement is undefined in this case.
Is it possible to just check on
e.srcElement === undefined?

EDIT:
Just found out that there is no attribute srcElement in this specific event (PointerEvent).
With e.originalEvent.srcElement I get my image. But then there will be a src attribute instead of a href attribute - depending on what type the srcElement is.
So your solutions seems to be specific but does not fit in other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbie-cahill @kchrismc