Skip to content

Exclude metadata/prerelease tags. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexbeltran
Copy link

Description

This PR extends the glob used for finding the last semver tag, ignoring any pre-release or metadata tags as stated in Issue #10 .

Important Information

To test, tag locally a metadata tag

e.g.) git tag v2.0.4-prod and run the command. git describe --tags --abbrev=0 --match="v[0-9]*\\.[0-9]*\\.[0-9]*" --exclude="v[0-9]*\\.[0-9]*\\.[0-9]*-*"

Versioning

This PR will bump the version by one fix level.

I've done the steps below, and they work properly:

  • Update/Add Tests
  • Manual sanity checking
Reviewers...
### I confirm that:
- [ ] PR addresses intended issue, with smallest scope possible
- [ ] Code is of acceptable quality
- [ ] Code is properly tested (quantity and quality)
- [ ] Bumping **minor** level is appropriate

Alex Beltran and others added 2 commits June 11, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant