Skip to content

Commit

Permalink
Use AbbreviatedTypes 0.3 feature
Browse files Browse the repository at this point in the history
  • Loading branch information
@wsshin
wsshin committed Nov 19, 2022
1 parent 1b67404 commit 9875b20
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/GeometryPrimitives.jl
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module GeometryPrimitives
using AbbreviatedTypes
using AbbreviatedTypes; @define_types_with(Float64)
using LinearAlgebra
using Statistics: mean
using Makie
Expand Down

3 comments on commit 9875b20

@wsshin
Copy link
Collaborator Author

@wsshin wsshin commented on 9875b20 Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/72412

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.5 -m "<description of version>" 9875b20a1b48306f0e3c21de9423480822d47f87
git push origin v0.4.5

@smartalecH
Copy link
Contributor

@smartalecH smartalecH commented on 9875b20 Jan 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is breaking the current tests.

Your new version of AbbreviatedTypes.jl keeps parameters like τᵣ₀ within the namespace of the package. Many of the tests (which reside outside the namespace) use these constants without referencing the proper namespace. eg. see here:

GeometryPrimitives.jl/test/runtests.jl

Lines 8 to 10 in 9576f67

const one⁻ = 1 - τᵣ₀ # scale factor slightly less than 1
const one⁺ = 1 + τᵣ₀ # scare factor slightly greater than 1
const one⁻⁻, one⁺⁺ = 0.9, 1.1 # (scale factor less than 1, scale factor greater than 1)

Unfortunately we can't use the older version of AbbreviatedTypes.jl because the macro introduced here (@define_types_with) is only in the new version of AbbreviatedTypes.jl.

So one needs to either update all the tests with the proper namespace, or revert this commit and use an older version of AbbreviatedTypes.jl.

(cc @stevengj )

Please sign in to comment.