Several fixes and all other PRs #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the `DateError` struct was public, there was no way to create one with the publicly available items. Now, the `date_error` and `date_result` items are public, so users can create `DateError`s. This can be useful, for example, when the user wants a function to return a `DateResult` but performs some additional validation in addition to the validation performed by the `parse_duration` function. Now, users can perform the validation and return a `DateError` if the validation fails.
Previously, the publicly available structs and enums only implemented `Debug` (and maybe `PartialEq`). Now, they implement most commonly used traits from the standard library. This makes them much easier to use.
While the chrono-engligh tests depend on the `clock` feature, it's not used as part of the non-test chrono-english. This turns off the feature to reduce the dependencies needed by downstream libraries and applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
Incorporates #28, #26, #25, #21
This MR does a few things for your convenience:
fmt, this has already been done by @HarrissonMc555.Open tasks:
This state seems to work, the tests pass and it can be used to publish a preliminary release that fixes most issues of the community.
@stevedonovan
After taking a look at #22, if you require help in releasing this crate, I would be open to hop into a call with you. I'll introduce you to a bit of nice tooling such as cargo-release and a few best-practices on how to do this :).
This would then also fix #22 and #27