fix: don't reference globalThis.Buffer when env=browser (#967) #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated bytesFromBase64 and base64FromBytes functions now only include code that's required for the specified env: For env=node, the functions now exclusively use globalThis.Buffer to de-/encode to and from JSON For env=browser, globalThis.btoa/atob is used For env=both, the two functions use either the node or browser implementations depending on whether globalThis.Buffer exists
|
This is great @cmd-johnson , thank you! |
|
🎉 This PR is included in version 1.167.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled over #967 today. The code generated by ts-proto includes references to
globalThis.Buffer, even though theenvoption is set tobrowser.While the transpiled code still works in the browser, TypeScript (when using strict mode) complains that
error TS7017: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature..The fix is relatively simple: update the
makeByteUtilsfunction inmain.tsand only emit the implementations matching chosen environment:env=node, the emittedbytesFromBase64andbase64FromBytesfunctions now exclusively useglobalThis.Bufferto de-/encode to and from base64env=browser,globalThis.btoa/globalThis.atobare usedenv=both, the emitted functions work as before: they check forglobalThis.Bufferand use either the node or browser implementations accordingly