feat: Allow comments to be omitted #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
force-pushed
the
disable-comments
branch
from
6ae95b3 to
1b0f802
Compare
stephenh
pushed a commit
that referenced
this pull request
Jan 22, 2024
# [1.167.0](v1.166.4...v1.167.0) (2024-01-22) ### Features * Allow comments to be omitted ([#989](#989)) ([cb7eef7](cb7eef7))
|
🎉 This PR is included in version 1.167.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ship generated code as part of a package, but it's an internal implementation detail so the comments that get copied from the proto files are just wasted bytes.
This adds a
commentsoption which defaults totrue(maintaining the current behaviour), but may be set tofalseto omit comments from the generated code.