feat: Make sure all types support prefix/suffix #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a little scared of how big this change is. And I was trying to save some battery power so didn't run complete test suite on my laptop. |
halkeye
force-pushed
the
typeprefix-everything
branch
from
a41e1d5 to
29652e9
Compare
|
seems to be happy. |
stephenh
approved these changes
Dec 9, 2024
| @@ -344,3 +344,7 @@ async function readPackageJson(): Promise<any> { | |||
| return await import("../package.json" as string); | |||
| } | |||
| } | |||
|
|
|||
| export function wrapTypeName(options: Options, name: string) { | |||
| @@ -11,7 +11,7 @@ export function generateEncoder(ctx: Context, typeName: string): Code { | |||
| } | |||
|
|
|||
| if (name == "Timestamp") { | |||
| const TimestampValue = impProto(ctx.options, "google/protobuf/timestamp", name); | |||
| const TimestampValue = impProto(ctx.options, "google/protobuf/timestamp", wrapTypeName(ctx.options, name)); | |||
There was a problem hiding this comment.
Ah sure, makes sense we need to wrap all of these imports 👍
stephenh
pushed a commit
that referenced
this pull request
Dec 9, 2024
# [2.6.0](v2.5.1...v2.6.0) (2024-12-09) ### Features * Make sure all types support prefix/suffix ([#1148](#1148)) ([ddf2122](ddf2122))
|
🎉 This issue has been resolved in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.