Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: google protobuf timestamps don't properly get suffixed when useDate=false and prefix/suffix #1146

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: google protobuf timestamps don't properly get suffixed when useDate=false and prefix/suffix #1146

merged 1 commit into from
Dec 9, 2024

Conversation

halkeye
Copy link
Contributor

@halkeye halkeye commented Dec 9, 2024

No description provided.

@halkeye
Copy link
Contributor Author

halkeye commented Dec 9, 2024

Also when I ran the yarn build:test && yarn test type stuff i ended up with some uncommitted files, not sure if thats right?

        integration/output-decode-include-types/google/
        integration/output-encode-decode-include-types-combined/google/
        integration/output-encode-include-types/google/

@stephenh
Copy link
Owner

stephenh commented Dec 9, 2024

Looks great, thnaks @halkeye !

Per the uncommitted files, it's likely some of the last few contributors didn't include them.

If you'd like to do a separate PR that adds them, that'd be great, but also np/I can get around to it eventually as well. Thanks!

@stephenh stephenh merged commit 53f799e into stephenh:main Dec 9, 2024
6 checks passed
stephenh pushed a commit that referenced this pull request Dec 9, 2024
@semantic-release-bot
chore(release): 2.5.1 [skip ci]
14a55ee 
## [2.5.1](v2.5.0...v2.5.1) (2024-12-09)

### Bug Fixes

* google protobuf timestamps don't properly get suffixed when useDate=false and prefix/suffix ([#1146](#1146)) ([53f799e](53f799e))
@stephenh
Copy link
Owner

stephenh commented Dec 9, 2024

🎉 This issue has been resolved in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@halkeye
Copy link
Contributor Author

halkeye commented Dec 9, 2024

If you'd like to do a separate PR that adds them, that'd be great, but also np/I can get around to it eventually as well. Thanks!

#1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halkeye @stephenh