feat: Avoid adding empty trailing comments to oneof unions #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
changed the title
haines
force-pushed
the
empty-oneof-comments
branch
from
d418fb8 to
61264ab
Compare
haines
added a commit
to cerbos/cerbos-sdk-javascript
that referenced
this pull request
Nov 25, 2024
stephenh/ts-proto#1140 Signed-off-by: Andrew Haines <[email protected]>
haines
added a commit
to cerbos/cerbos-sdk-javascript
that referenced
this pull request
Nov 25, 2024
* chore(deps-dev): update development dependencies Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Avoid adding empty trailing comments to oneof unions stephenh/ts-proto#1140 Signed-off-by: Andrew Haines <[email protected]> --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Andrew Haines <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrew Haines <[email protected]>
|
🎉 This issue has been resolved in version 2.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the output from #1136 slightly to avoid adding the trailing
//after the union member separator if there isn't a documentation comment for the following oneof field (or if comments are turned off).