Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: problem with verbatimModuleSyntax for grpc-js #1132

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

rosek86
Copy link
Contributor

@rosek86 rosek86 commented Nov 10, 2024

Hello, I have a few issues when verbatimModuleSyntax is enabled:

image

@rosek86 rosek86 changed the title fix problem with verbatimModuleSyntax for grpc-js fix: problem with verbatimModuleSyntax for grpc-js Nov 10, 2024
@stephenh
Copy link
Owner

hi @rosek86 , thanks for the fix! Can you run yarn proto2ts and push up the files that change? Having the codegen files in the PRs is basically how we do acceptance/regression testing. Thanks!

@rosek86
Copy link
Contributor Author

rosek86 commented Nov 10, 2024

done

@stephenh
Copy link
Owner

Thanks @rosek86 !

@stephenh stephenh merged commit bedfa31 into stephenh:main Nov 11, 2024
6 checks passed
stephenh pushed a commit that referenced this pull request Nov 11, 2024
## [2.2.7](v2.2.6...v2.2.7) (2024-11-11)

### Bug Fixes

* problem with verbatimModuleSyntax for grpc-js ([#1132](#1132)) ([bedfa31](bedfa31))
@stephenh
Copy link
Owner

🎉 This issue has been resolved in version 2.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants