Don't check for default entries in toJson when using proto2

stephenh · Nov 9, 2024 · c9fc51a · c9fc51a
1 parent c90f285
commit c9fc51a
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 49 deletions.
diff --git a/integration/extensions/test.ts b/integration/extensions/test.ts
diff --git a/integration/map-long-optional/test.ts b/integration/map-long-optional/test.ts
diff --git a/integration/proto2-long/simple.ts b/integration/proto2-long/simple.ts
diff --git a/src/types.ts b/src/types.ts
@@ -351,7 +351,7 @@ export function notDefaultCheck(
     case FieldDescriptorProto_Type.TYPE_INT64:
     case FieldDescriptorProto_Type.TYPE_SINT64:
     case FieldDescriptorProto_Type.TYPE_SFIXED64:
-      if (options.forceLong === LongOption.LONG && !isJsTypeFieldOption(options, field)) {
+      if (options.forceLong === LongOption.LONG && !isJsTypeFieldOption(options, field) && ctx.currentFile.isProto3Syntax) {
         return code`${maybeNotUndefinedAnd} !${place}.equals(${defaultValue(ctx, field)})`;
       } else {
         return code`${maybeNotUndefinedAnd} ${place} !== ${defaultValue(ctx, field)}`;