Fix type resolvability for non-grpc implementation of unwrapped rpc args

stephenh · Dec 21, 2023 · bf73457 · bf73457
1 parent a48061a
commit bf73457
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/integration/wrappers-regression/wrappers-regression.ts b/integration/wrappers-regression/wrappers-regression.ts
@@ -34,7 +34,7 @@ export class ClockClientImpl implements Clock {
   }
 
   NowString(request: string | undefined): Promise<StringValue> {
-    const data = StringValue.encode({ value: request }).finish();
+    const data = StringValue.encode(StringValue.fromPartial({ value: request })).finish();
     const promise = this.rpc.request(this.service, "NowString", data);
     return promise.then((data) => StringValue.decode(_m0.Reader.create(data)));
   }

diff --git a/src/generate-services.ts b/src/generate-services.ts
@@ -133,8 +133,9 @@ function generateRegularRpcMethod(ctx: Context, methodDesc: MethodDescriptorProt
     `;
   }
 
-  const inputValue = isValueType && !methodDesc.clientStreaming ? '{ value: request }' : 'request';
-  let encode = code`${rawInputType}.encode(${inputValue}).finish()`;
+  let encode = isValueType && !methodDesc.clientStreaming
+    ? code`${rawInputType}.encode(${rawInputType}.fromPartial({ value: request })).finish()`
+    : code`${rawInputType}.encode(request).finish()`;
   let beforeRequest;
   if (options.rpcBeforeRequest) {
     beforeRequest = code`