Cheat bugfix and new A8 cheat type #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added needed g_emu_thread->reloadCheats calls after the reloadList() calls on entering a new code or importing new codes. Without it I had to import new codes and then manually edit one of them for it to show up in the cheat counts and possibly even work
Added cheat type A8 which is the byte equivalent of the A7 cheat type as there will be a need of this type.
PugsyMAME
changed the title
stenzek
reviewed
Nov 10, 2024
| @@ -529,6 +529,7 @@ void GameCheatSettingsWidget::importCodes(const std::string& file_contents) | |||
| } | |||
|
|
|||
| reloadList(); | |||
| g_emu_thread->reloadCheats(true, true, false, true); | |||
There was a problem hiding this comment.
I'm not sure about this. It shouldn't need to reload cheats, since the one you just imported should not be enabled yet.
Once you click the checkbox, it should trigger a reload.
There was a problem hiding this comment.
You mentioned on Discord what the bools should be and I can confirm that true, false,false ,true works for both lines.
g_emu_thread->reloadCheats(true, false, false, true);
I've updated it on my master branch to reflect this.
Changed boolean parameters in last PR as per discord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without it I had to import new codes and then manually edit one of them for it to show up in the cheat counts and possibly even work