-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ✨ Initial draft of functions to extract osdc population #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I've added a few comments just to FYI a few details.
I think that #69 will eventually merge/move into this document.
I revised the doc and images a bit, mostly adding the input register source, converting it to a flow chart to show the interconnection with some of the functions and output data as input to other functions. I also added a function convention section so we have at least a guidelines for naming things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `calculate_pregnancy_index_date_for_mc_visits_wo_end_date()` (this | ||
might be removed with the inclusion of the birth register) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what this does.
vignettes/images/function-flow.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aastedet you'll have to confirm if the input registers are correct for each inclusion/exclusion function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very niceeee @lwjohnst86. I really like the clarity of the naming scheme 🎉
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
@lwjohnst86 @Aastedet I have updated this again based on the feedback I got from Luke, so I'll re-request reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Luke W. Johnston <[email protected]>
Co-authored-by: Luke W. Johnston <[email protected]>
Description
This PR describes the functions for extracting a diabetes population using the
osdc
package.See issue #67.
As we have discussed, this is an initial draft meant to help us specify exactly what we want to build.
So please chime in with questions, suggestions, and corrections.
As @Aastedet wrote here there is an overlap between #69 and this PR. @lwjohnst86 can you help us in terms of what should be in each post?