feat: ✨ add include_gld_purchases()
#138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aastedet
reviewed
Sep 19, 2024
| dplyr::rename(date = eksd) |> | ||
| dplyr::relocate(atc, .after = date) | ||
|
|
||
| test_that("dataset needs expected variables", { |
There was a problem hiding this comment.
The algorithm needs either the "name" or "vnr" variable to work, so we should add this to the tests and the inclusion function itself (e.g. check for any of the variables in the input data and use the one that is available (and use "name" by default if both are available).
There was a problem hiding this comment.
After testing, it turns out we don't need "name" nor "vnr" any more, so this comment is irrelevant now.
signekb
reviewed
Sep 19, 2024
lwjohnst86
commented
Sep 19, 2024
Co-authored-by: Luke W. Johnston <[email protected]>
Aastedet
approved these changes
Sep 19, 2024
signekb
reviewed
Sep 19, 2024
signekb
reviewed
Sep 19, 2024
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
|
/document |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92.
Adding the
include_gld_purchases()function. For adding the logic to thealgorithmdataframe, I used the symbol=~to indicate it is a regex, since that's how it was done in Perl and it's the only other symbol I could find to represent regexes.Several files were updated, but mainly because I re-ran the targets pipeline☺️
Please, focus mainly on the tests and the function itself 🥳