-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 📝 expand on inclusions and exclusions #133
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
Since the Can we do this as-is (my uneducation opinion), or do we need to change the function name? |
…he inputs go to exclusion functions
…s/osdc into update-function-flow
@Aastedet it sounds like we need some processing before joining then. Could you document those filtering steps in the function flow/design docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming along nicely!! Just some comments for now.
…s/osdc into update-function-flow
Autoformatting made a few changes after resolving previous merge conflict.
Yes - I've added them in the latest commit |
…drugs with a dual-use for weightloss.
Co-authored-by: Luke W. Johnston <[email protected]>
…s/osdc into update-function-flow
Reformatted output variable lists to start with variable names, followed by a short description. Also added info on renamed variables.
…e_lpr2() function
ChatGPT seems to understand what I'm trying to describe (although it shouldn't apply the exclusion functions just yet): https://chatgpt.com/share/66eab6f4-0ffc-800a-aedb-d9dae21c48c3 😄
Closes #130
Closes #140