Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 expand on inclusions and exclusions #133

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Aastedet
Copy link
Collaborator

@Aastedet Aastedet commented Sep 18, 2024

ChatGPT seems to understand what I'm trying to describe (although it shouldn't apply the exclusion functions just yet): https://chatgpt.com/share/66eab6f4-0ffc-800a-aedb-d9dae21c48c3 😄

Closes #130
Closes #140

vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
@Aastedet Aastedet marked this pull request as ready for review September 19, 2024 11:40
@lwjohnst86 lwjohnst86 changed the title Fleshed out and updated include_gld_purchases() flow documentation docs: 📝 expand on inclusions and exclusions Sep 19, 2024
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
@Aastedet
Copy link
Collaborator Author

Since the join_lpr2() and join_lpr3() functions already perform variable selection, we should also include a baseline filtering operation, since that is what we would do in practice to avoid processing unnecessary data: load-> select variables -> filter to only diagnoses relevant to the osdc package (similar to how the include_gld_purchases() function filters to A10*).

Can we do this as-is (my uneducation opinion), or do we need to change the function name?

@lwjohnst86
Copy link
Member

@Aastedet it sounds like we need some processing before joining then. Could you document those filtering steps in the function flow/design docs?

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coming along nicely!! Just some comments for now.

vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
@Aastedet
Copy link
Collaborator Author

@Aastedet it sounds like we need some processing before joining then. Could you document those filtering steps in the function flow/design docs?

Yes - I've added them in the latest commit

vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
vignettes/function-flow.Rmd Outdated Show resolved Hide resolved
Anders Aasted Isaksen added 2 commits September 27, 2024 12:05
Reformatted output variable lists to start with variable names, followed by a short description. Also added info on renamed variables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Document join() functions Go through the function flow vignette and fill in missing function info
3 participants