Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📝 update with version 1.1 validation metrics #129

Merged
merged 3 commits into from
Sep 18, 2024
Merged

docs: 📝 update with version 1.1 validation metrics #129

merged 3 commits into from
Sep 18, 2024

Conversation

Aastedet
Copy link
Collaborator

@Aastedet Aastedet commented Aug 20, 2024 •
edited by lwjohnst86
Loading

Now includes simplified de-duplication of HbA1c and pregnancy definitions (see description in document) and the accuracy is slightly better overall, and particularly in the small, atypical groups (T1D old at diagnosis & T2D young at diagnosis). Very happy it turned out this way!

Closes #107, closes #74

Added validation metrics for the updated version, including simplied …
01a1230 
…pregnancy definitions and HbA1c de-duplication by date.
@Aastedet Aastedet linked an issue Aug 20, 2024 that may be closed by this pull request
Explore if GDM censoring can be simplified #74
Closed
lwjohnst86
lwjohnst86 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Only a small comment in relation to @signekb comment.

vignettes/changes.Rmd Show resolved Hide resolved
signekb
signekb reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@signekb signekb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll comment instead of approving, since I had one (more) comment after all. See above ⬆️

@signekb signekb changed the title Updates changes and added validation metrics after testing docs: memo: Updates changes with new validation metrics Sep 18, 2024
@signekb signekb changed the title docs: memo: Updates changes with new validation metrics docs: 📝 Update changes with new validation metrics Sep 18, 2024
@signekb signekb changed the title docs: 📝 Update changes with new validation metrics docs: 📝 update changes with new validation metrics Sep 18, 2024
@signekb signekb changed the title docs: 📝 update changes with new validation metrics docs: 📝 update with version 1.1 validation metrics Sep 18, 2024
@signekb signekb merged commit f988528 into main Sep 18, 2024
2 of 3 checks passed
@signekb signekb deleted the docs-validated-changes branch September 18, 2024 13:55
@Aastedet
Copy link
Collaborator Author

closed #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signekb signekb signekb approved these changes

@lwjohnst86 lwjohnst86 lwjohnst86 approved these changes

Assignees

@Aastedet Aastedet

Labels
None yet
Projects
osdc development planning board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test simpler ways to de-duplication of HbA1c Explore if GDM censoring can be simplified
3 participants
@Aastedet @lwjohnst86 @signekb