Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sysdata.rda that contains the same as variable-description.rda #123

Closed
wants to merge 1 commit into from

Conversation

signekb
Copy link
Contributor

@signekb signekb commented Jun 19, 2024

Description

I noticed that under the R folder there's a sysdata.Rda that seems to contain the same as data/variable-description.Rda.
I assume that we don't want data in the R folder?

@lwjohnst86
Copy link
Member

Ah, maybe should have explained this file. This sysdata file gets generated whenever you use usethis::use_data(internal = TRUE). I need to confirm, this but I tried to run some code without the internal data, for instance for the verify_required_variables(), and it didn't work. I think it is because data in the data/ folder is "lazy loaded", meaning it is only loaded when it is actively called. But internal functions I guess can't easily actively call the data there, so it has to be internal.

@signekb
Copy link
Contributor Author

signekb commented Jun 19, 2024

Ah! Alrighty! Will close this then 👍

@signekb signekb closed this Jun 19, 2024
@lwjohnst86 lwjohnst86 deleted the fix/remove-sysdata.rda branch June 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants