Repair stencil-route-prompt (ask user for confirmation before navigation) #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const getUserConfirmation = | ||
| props.getUserConfirmation != null | ||
| ? props.getUserConfirmation | ||
| : getConfirmation.bind(undefined, win); |
There was a problem hiding this comment.
Ensure window is passed as first parameter to getConfirmation.
| @@ -103,7 +104,7 @@ const createBrowserHistory = (win: Window, props: CreateBrowserHistoryOptions = | |||
| ); | |||
| }; | |||
|
|
|||
| const handlePopState = (event: any) => { | |||
| const handlePopState = (event: PopStateEvent) => { | |||
There was a problem hiding this comment.
Misc. clean up discovered while reading through code. Seemed like a specific type would be better.
| @@ -52,7 +52,7 @@ const createHashHistory = (win: Window, props: CreateHashHistoryOptions = {}) => | |||
| const keyLength = (props.keyLength != null) ? props.keyLength : 6; | |||
|
|
|||
| const { | |||
| getUserConfirmation = getConfirmation, | |||
| getUserConfirmation = getConfirmation.bind(undefined, win), | |||
There was a problem hiding this comment.
Ensure window is passed as first parameter to getConfirmation.
michael-speed-elder
changed the title
When `create***History` runs, `getUserConfirmation` defaults to the `getConfirmation` function, which expects the global `window` object as its first parameter. However, it is later invoked without passing `window`, probably because the signature for the user-defined flavor in `CreateBrowserHistoryOptions` does not expect `window` to be passed. The simple fix is to bind `window` to the default `getConfirmation` function as its first parameter.
michael-speed-elder
force-pushed
the
fix-stencil-route-prompt
branch
from
b4b2262
to
6de5c7b
Compare
| this.disable(); | ||
| } else if (prevMessage !== newMessage) { | ||
| this.enable(this.message); |
There was a problem hiding this comment.
Tried to simplify the logic here a little while being more earnest about the parameter types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to require confirmation before navigation under certain circumstances. From reading the code, it is clear this was almost a supported mechanism, and only minor tweaks are required to achieve that functionality through the
<stencil-route-prompt>component.When
createBrowserHistoryorcreateHashHistoryruns,getUserConfirmationdefaults to thegetConfirmationfunction, which expects the globalwindowobject as its first parameter. However, it is later invoked without passingwindow, probably because the signature for the user-defined flavor inCreateBrowserHistoryOptionsdoes not expectwindowto be passed.The simple fix is to bind
windowto the defaultgetConfirmationfunction as its first parameter.I also have doc files written for the wiki: wiki-changes.zip